Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should reject x.y.(z+1) if x.y.z has not been merged #225

Open
StefanKarpinski opened this issue Sep 28, 2019 · 2 comments
Open

should reject x.y.(z+1) if x.y.z has not been merged #225

StefanKarpinski opened this issue Sep 28, 2019 · 2 comments

Comments

@StefanKarpinski
Copy link
Contributor

People keep opening flights of PRs to register versions 0.1.2, 0.1.3, 0.1.4 and 0.1.5—all before 0.1.2 has been merged. Registrator should reject such attempts and direct the package author to update 0.1.2 instead. Similarly, if there's a PR to register a package with one version number, say 0.1.0, if the author tries to register the same package with a different version number, say 1.0.0, Registrator should refuse and instruct the author to update the original PR.

@DilumAluthge
Copy link
Member

This is... partially fixed by automerge? Automerge only merges if the version bump is one of the following:

  • a.b.c to a.b.(c+1). For example, 1.2.3 to 1.2.4
  • a.b.c to a.(b+1).0. For example, 1.2.3 to 1.3.0
  • a.b.c to (a+1).0.0. For example, 1.2.3 to 2.0.0

So it doesn’t fully solve the problem. But certainly we don’t automerge PR’s that don’t follow those rules.

@StefanKarpinski
Copy link
Contributor Author

Yes, definitely helps but registration should not be allowed in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants