Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ChainRules v0.2.3 #4842

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 082447d4-558c-5d27-93f4-14fc19e9eca2
Repo: https://github.com/JuliaDiff/ChainRules.jl.git
Tree: f2c11b316de0460396a6e4c2a4b20acdf6b3c171

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
JuliaRegistrator referenced this pull request in JuliaDiff/ChainRules.jl Oct 29, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

Your new version pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • Does not meet sequential version number guideline
  • The following dependencies do not have a compat entry that has an upper bound: Reexport, Requires

If you want to prevent this pull request from being auto-merged, simply leave a comment.

(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)


It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@oxinabox
Copy link
Contributor

Close infavor of #4845

idk why New PR was openned rather than this one being editted but it was

@fredrikekre
Copy link
Member

idk why New PR was openned rather than this one being editted but it was

You updated the version number.

@fredrikekre fredrikekre deleted the registrator/chainrules/082447d4/v0.2.3 branch October 29, 2019 11:46
@oxinabox
Copy link
Contributor

You updated the version number.

@JuliaRegistrator said it would update the PR:

Also, note the warning: Version 0.2.3 skips over 0.2.2
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

JuliaDiff/ChainRules.jl@80de568#commitcomment-35707937

@fredrikekre
Copy link
Member

Okay, yea that's wrong. Since we allow multiple open PRs for the same package (JuliaRegistries/Registrator.jl#225 for example) we have to make a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants