-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AutoMerge: last run blocked by comment
and Override AutoMerge: ignore blocking comments
labels
#573
Conversation
… ignore blocking comments` labels
Unit tests on Julia 1.3 should be fixed now after JuliaRegistries/General#112623. I'll retry that job. |
Is there a way to try the integration tests without merging? |
We could add a |
All of this work is done in the cron job, right? This doesn't change anything in the PR job? I haven't done a line-by-line review of the code, but at a high level, I understand the motivation here:
|
Yep, exactly. The “blocked” label is intended to be managed entirely by the cron job to communicate status, and is set and removed by it. If a human adds or removes it, it will just be corrected next cron run to surface the actual status. The override label is never set or removed by the cron job, only read. It allows ignoring blocking comments; it’s easier than editing “noblock” into every comment, and it allows triage members to overrule community blocks if necessary. I hope these have the following effects:
|
Those details sound good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed the code diff line-by-line, but the high-level plan sounds good to me.
ok, think this is ready to go. I believe it is non-breaking, since while it needs write permissions for the PR, it is part of the cron job which needs merging permissions anyway. It does not add or remove labels in |
test/automerge-integration.jl
Outdated
sleep(1) | ||
# Check we no longer have the blocked label | ||
labels = GitHub.labels(repo, pr) | ||
@test !AutoMerge.has_label(labels, AutoMerge.BLOCKED_LABEL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is failing, but I'm not sure why. The label does seem to be deleted (bcbi-test/automerge-integration-test-repo#11079)
This is the first RegistryCI feature that involves adding/removing labels programatically, as opposed to previous work that only reads them. This only affects the cron job. When it runs, it
Specifically, the permissions needed are: the github token by the cron job needs at least one of: