Make QBasedPolicy general for AbstractLearner s #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jeremiahpslewis merged 1 commit into JuliaReinforcementLearning:main from dharux:main

Apr 18, 2024

Contributor

dharux commented Apr 17, 2024 •

edited

Loading

Makes the QBasedPolicy work with general learner algorithms rather than a highly restrictive TDLearner algorithm.

PR Checklist

Update NEWS.md?
Unit tests for all structs / functions?
Integration and correctness tests using a simple env?
PR Review?
Add or update documentation?
Write docstrings for new methods?


          Make QBasedPolicy general for AbstractLearner s

0f2217c

Member

jeremiahpslewis commented Apr 17, 2024

Thanks for the PR! Looks good to me, just waiting on #1071 which will fix the remaining (unrelated) failing test.

jeremiahpslewis self-requested a review

April 18, 2024 11:32

jeremiahpslewis approved these changes

View reviewed changes

jeremiahpslewis merged commit 30f3105 into JuliaReinforcementLearning:main

29 of 38 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet