Skip to content

fixing prob. /w symbol/ string correspondence #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mytolo
Copy link
Contributor

@Mytolo Mytolo commented Jul 24, 2023

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

PettingZoo environments had problems with agent identification symbol to string conversion. Was just a minor bug after readjusting the wrapper here.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #934 (1431a78) into main (1f7f347) will decrease coverage by 13.65%.
The diff coverage is 0.00%.

❗ Current head 1431a78 differs from pull request most recent head 5d951b1. Consider uploading reports for the commit 5d951b1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #934       +/-   ##
==========================================
- Coverage   13.64%   0.00%   -13.65%     
==========================================
  Files         217     208        -9     
  Lines        7571    7410      -161     
==========================================
- Hits         1033       0     -1033     
- Misses       6538    7410      +872     
Files Changed Coverage Δ
...ironments/src/environments/3rd_party/pettingzoo.jl 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

@jeremiahpslewis jeremiahpslewis merged commit 9202202 into JuliaReinforcementLearning:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants