Skip to content

Drop deprecated @provide interface #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

jeremiahpslewis
Copy link
Member

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #944 (002ec38) into main (01b0121) will increase coverage by 25.54%.
The diff coverage is 0.00%.

❗ Current head 002ec38 differs from pull request most recent head 2df446b. Consider uploading reports for the commit 2df446b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #944       +/-   ##
==========================================
+ Coverage   0.00%   25.54%   +25.54%     
==========================================
  Files        209      223       +14     
  Lines       7411     7736      +325     
==========================================
+ Hits           0     1976     +1976     
+ Misses      7411     5760     -1651     
Files Changed Coverage Δ
...ReinforcementLearningBase/src/CommonRLInterface.jl 26.08% <0.00%> (+26.08%) ⬆️

... and 70 files with indirect coverage changes

@jeremiahpslewis jeremiahpslewis merged commit 82bcbe1 into main Aug 4, 2023
@jeremiahpslewis jeremiahpslewis deleted the jpsl/provided-deprecation branch August 4, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant