Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another ls2 dispatch #1036

Merged
merged 1 commit into from
Aug 16, 2023
Merged

another ls2 dispatch #1036

merged 1 commit into from
Aug 16, 2023

Conversation

dehann
Copy link
Member

@dehann dehann commented Aug 16, 2023

No description provided.

@dehann dehann requested a review from Affie August 16, 2023 20:14
@dehann dehann self-assigned this Aug 16, 2023
@dehann dehann added enhancement New feature or request API labels Aug 16, 2023
@dehann dehann added this to the v0.23.2 milestone Aug 16, 2023
Comment on lines 662 to 664
l2 = getNeighborhood(dfg, label, 2)
l1 = getNeighborhood(dfg, label, 1)
return setdiff(l2, l1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
l2 = getNeighborhood(dfg, label, 2)
l1 = getNeighborhood(dfg, label, 1)
return setdiff(l2, l1)
l2 = getNeighborhood(dfg, label, 2)
l1 = getNeighborhood(dfg, label, 1)
return setdiff(l2, l1)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1036 (872b50d) into master (6b8ffb2) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   78.71%   78.67%   -0.04%     
==========================================
  Files          26       26              
  Lines        2147     2148       +1     
==========================================
  Hits         1690     1690              
- Misses        457      458       +1     
Files Changed Coverage Δ
src/services/AbstractDFG.jl 83.29% <0.00%> (-0.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann dehann merged commit 6dce1d8 into master Aug 16, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants