Fix mergeBlobEntries! #1039
Merged
Fix mergeBlobEntries! #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
added
bug fix
data: entry=>blob
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
371
to
378
| des = listBlobEntries(src, slbl) | ||
| # don't add data entries that already exist | ||
| dde = listBlobEntries(dst, dlbl) | ||
| # HACK, verb list should just return vector of Symbol. NCE36 | ||
| _getid(s) = s | ||
| _getid(s::BlobEntry) = s.id | ||
| uids = _getid.(dde) # (s->s.id).(dde) | ||
| filter!(s -> !(_getid(s) in uids), des) | ||
| uids = listBlobEntries(dst, dlbl) | ||
| # verb list should just return vector of Symbol. NCE36 | ||
| filter!(s -> !(s in uids), des) | ||
| if 0 < length(des) | ||
| union(((s->mergeBlobEntries!(dst, dlbl, src, slbl, s.id)).(des))...) | ||
| union(((s->mergeBlobEntries!(dst, dlbl, src, slbl, s)).(des))...) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| des = listBlobEntries(src, slbl) | |
| # don't add data entries that already exist | |
| dde = listBlobEntries(dst, dlbl) | |
| # HACK, verb list should just return vector of Symbol. NCE36 | |
| _getid(s) = s | |
| _getid(s::BlobEntry) = s.id | |
| uids = _getid.(dde) # (s->s.id).(dde) | |
| filter!(s -> !(_getid(s) in uids), des) | |
| uids = listBlobEntries(dst, dlbl) | |
| # verb list should just return vector of Symbol. NCE36 | |
| filter!(s -> !(s in uids), des) | |
| if 0 < length(des) | |
| union(((s->mergeBlobEntries!(dst, dlbl, src, slbl, s.id)).(des))...) | |
| union(((s->mergeBlobEntries!(dst, dlbl, src, slbl, s)).(des))...) | |
| end | |
| des = listBlobEntries(src, slbl) | |
| # don't add data entries that already exist | |
| uids = listBlobEntries(dst, dlbl) | |
| # verb list should just return vector of Symbol. NCE36 | |
| filter!(s -> !(s in uids), des) | |
| if 0 < length(des) | |
| union(((s -> mergeBlobEntries!(dst, dlbl, src, slbl, s)).(des))...) | |
| end |
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 77.94% 78.05% +0.10%
==========================================
Files 26 26
Lines 2181 2178 -3
==========================================
Hits 1700 1700
+ Misses 481 478 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.