Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix, getData with UUID #1048

Merged
merged 6 commits into from
Sep 10, 2023
Merged

bug fix, getData with UUID #1048

merged 6 commits into from
Sep 10, 2023

Conversation

dehann
Copy link
Member

@dehann dehann commented Sep 5, 2023

No description provided.

@dehann dehann added bug fix data: entry=>blob Previously bigdata, suggested over `smalldata` labels Sep 5, 2023
@dehann dehann self-assigned this Sep 5, 2023
@dehann dehann added this to the v0.23.3 milestone Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1048 (1185cf7) into master (54f4e35) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   77.85%   78.22%   +0.37%     
==========================================
  Files          26       26              
  Lines        2271     2273       +2     
==========================================
+ Hits         1768     1778      +10     
+ Misses        503      495       -8     
Files Changed Coverage Δ
src/DataBlobs/services/BlobEntry.jl 58.55% <ø> (+5.26%) ⬆️
src/DataBlobs/services/HelpersDataWrapEntryBlob.jl 77.58% <100.00%> (+0.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie
Copy link
Member

Affie commented Sep 5, 2023

Maybe just add some tests if you don't mind. The coverage on HelpersDataWrapEntryBlob.j is not great.

@dehann dehann added the testing label Sep 10, 2023
test/testBlocks.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dehann dehann merged commit 378f6d0 into master Sep 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix data: entry=>blob Previously bigdata, suggested over `smalldata` testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants