Remove orphaned factors on deleteVariable! #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehann
reviewed
Apr 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 77.02% 85.61% +8.58%
==========================================
Files 36 36
Lines 1841 1967 +126
==========================================
+ Hits 1418 1684 +266
+ Misses 423 283 -140
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #296
Its a breaking change as the return type is changed and orphaned factors are removed from the graph, also see #338.
Orphaned factors are not currently supported and will be completely removed if they are not needed. (seems to be the case)