Skip to content

solverKey -> solveKey, fix #599 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged

solverKey -> solveKey, fix #599 #602

merged 1 commit into from
Aug 13, 2020

Conversation

dehann
Copy link
Member

@dehann dehann commented Aug 13, 2020

fix #599

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #602 into master will increase coverage by 6.34%.
The diff coverage is 86.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   73.55%   79.90%   +6.34%     
==========================================
  Files          33       33              
  Lines        2186     2190       +4     
==========================================
+ Hits         1608     1750     +142     
+ Misses        578      440     -138     
Impacted Files Coverage Δ
src/Deprecated.jl 0.00% <ø> (ø)
src/services/Serialization.jl 71.83% <ø> (ø)
src/CloudGraphsDFG/services/CloudGraphsDFG.jl 70.43% <81.25%> (+2.57%) ⬆️
src/services/DFGVariable.jl 88.35% <84.61%> (+7.53%) ⬆️
src/CloudGraphsDFG/services/CommonFunctions.jl 83.52% <100.00%> (ø)
src/entities/DFGVariable.jl 80.00% <100.00%> (+5.00%) ⬆️
src/LightDFG/FactorGraphs/BiMaps.jl 86.66% <0.00%> (+0.45%) ⬆️
src/entities/DFGFactor.jl 81.48% <0.00%> (+0.71%) ⬆️
src/services/AbstractDFG.jl 85.62% <0.00%> (+1.25%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182a5b6...061fcc3. Read the comment docs.

Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dehann dehann merged commit 7e1b6de into master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solveKey or solverKey
2 participants