Skip to content

Add elimination algorithms mcs, rcm, and mmd. #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

samuelsonric
Copy link

@samuelsonric samuelsonric commented Feb 24, 2025

This pull request adds some additional elimination algorithms:

  • mcs: maximum cardinality search
  • rcm: reverse Cuthill-Mckee
  • mmd: multiple minimum degree

The first two algorithms were implemented by me, and the third was taken from Sparspak.jl and lightly edited. The third algorithm, in particular, is quite good: it was the state of the practice before AMD, and it has the advantage of being MIT licensed.

@samuelsonric
Copy link
Author

I saw the issue with ManifoldsBase on my computer as well; I don't think it's related to my additions.

@Affie Affie requested a review from dehann February 24, 2025 17:59
@samuelsonric
Copy link
Author

samuelsonric commented Feb 26, 2025

More algorithms here.

@dehann
Copy link
Member

dehann commented Mar 4, 2025

Hi, acknowledged thanks -- will look soon. Thanks for the contribution, more elimination algorithms are definitely good!

@samuelsonric
Copy link
Author

samuelsonric commented Mar 5, 2025

Verson 0.5 has fewer dependencies. I also commented out the problematic manifolds tests.

@dehann dehann self-assigned this Mar 12, 2025
@dehann
Copy link
Member

dehann commented Mar 12, 2025

Update: I haven't forgotten -- been extra busy here with passing of a family member. Looking to work through this during travel this weekend. Apologies for the delay.

@samuelsonric
Copy link
Author

I am sorry to hear that. Please take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants