Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new csm test, no prior, #487

Merged
merged 8 commits into from
Dec 18, 2019
Merged

new csm test, no prior, #487

merged 8 commits into from
Dec 18, 2019

Conversation

dehann
Copy link
Member

@dehann dehann commented Dec 18, 2019

cc @GearsAD -- #485, thanks!

Need to resolve tree case where leaves have not factors, as occurred here:
#485 (comment)

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1ed5e81). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage          ?   46.43%           
=========================================
  Files             ?       29           
  Lines             ?     3754           
  Branches          ?        0           
=========================================
  Hits              ?     1743           
  Misses            ?     2011           
  Partials          ?        0
Impacted Files Coverage Δ
src/IncrementalInference.jl 66.66% <ø> (ø)
src/JunctionTree.jl 70.5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed5e81...1989d12. Read the comment docs.

@dehann dehann marked this pull request as ready for review December 18, 2019 18:51
@dehann dehann mentioned this pull request Dec 18, 2019
@dehann dehann merged commit b339a5e into master Dec 18, 2019
@dehann dehann modified the milestones: v0.8.x, v0.8.3 Dec 27, 2019
@dehann dehann deleted the test/4Q19/fix485 branch June 15, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants