Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build LCM in release mode #38

Merged
merged 3 commits into from
Apr 26, 2018
Merged

build LCM in release mode #38

merged 3 commits into from
Apr 26, 2018

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented Apr 26, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files           4        4           
  Lines         300      300           
=======================================
  Hits          265      265           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef88f4c...4877e9c. Read the comment docs.

@tkoolen
Copy link
Collaborator

tkoolen commented Apr 26, 2018

Does this also cause the tests to not be built?

@rdeits
Copy link
Collaborator Author

rdeits commented Apr 26, 2018

I'm not sure, but I'll check. Are you running the LCM C library tests?

@tkoolen
Copy link
Collaborator

tkoolen commented Apr 26, 2018

No no, I don't need the tests. I've just wondered why the tests were always being built. It feels like building the tests takes more time than actually building LCM itself. Not that build time is currently unbearable, but still.

@rdeits
Copy link
Collaborator Author

rdeits commented Apr 26, 2018

Ok, tests and examples are now disabled, which should help with compile time a little bit.

@rdeits rdeits merged commit a72f203 into master Apr 26, 2018
@rdeits rdeits deleted the build-release branch April 26, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants