Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #66, Problem building LCMCore from separate project. #67

Merged
merged 1 commit into from
May 29, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented May 27, 2019

One way to fix #66.

Let me know if you prefer a different solution.

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files           5        5           
  Lines         293      293           
=======================================
  Hits          244      244           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fd0e9...d704e88. Read the comment docs.

@tkoolen
Copy link
Collaborator Author

tkoolen commented May 29, 2019

Merging as I want this fixed ASAP, but please let me know if you want a different solution long-term.

@tkoolen tkoolen merged commit e33da6b into master May 29, 2019
@tkoolen tkoolen deleted the tk/fix-build branch May 29, 2019 18:06
tkoolen referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem building LCMCore from separate project
2 participants