Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poor performance when one of batch's arguments is a Type{...} #139

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

GianlucaFuwa
Copy link
Contributor

This PR is a fix for #116 by wrapping each argument of batch in a wrap_type function and using unwrap_type before the start of the loop body, as @chriselrod suggested. A test is included in runtests.jl.

Also made it such that batch always returns an empty Tuple when reduction is not used, since it used to be a Union{Nothing, Tuple{}}.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (c0ef9e1) to head (3038f82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   94.66%   93.29%   -1.37%     
==========================================
  Files           3        3              
  Lines         600      582      -18     
==========================================
- Hits          568      543      -25     
- Misses         32       39       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chriselrod chriselrod merged commit 12c4c60 into JuliaSIMD:master Mar 30, 2024
28 of 31 checks passed
@chriselrod
Copy link
Member

Thanks, this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants