Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to cut down heisen allocations to no avail #25

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

chriselrod
Copy link
Member

@chriselrod chriselrod commented Oct 12, 2022

Fixes #21 because I'm leaving precompiles off.

The only reliable strategy for removing allocations appears to be editing multithread_rdiv! with Revise.

…tegy appears to be editing `multithread_rdiv!` with Revise
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 87.50% // Head: 88.78% // Increases project coverage by +1.28% 🎉

Coverage data is based on head (f2ce9ef) compared to base (7fa5823).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   87.50%   88.78%   +1.28%     
==========================================
  Files           1        1              
  Lines         312      312              
==========================================
+ Hits          273      277       +4     
+ Misses         39       35       -4     
Impacted Files Coverage Δ
src/TriangularSolve.jl 88.78% <100.00%> (+1.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chriselrod chriselrod merged commit 8e2d7e4 into main Oct 14, 2022
@chriselrod chriselrod deleted the liballocsbutiamgivingup branch October 14, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck on precompiling after upgrading to 1.8
1 participant