Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed examples to match tuples due to expression change, updated so… #48

Closed
wants to merge 1 commit into from

Conversation

BCRARL
Copy link

@BCRARL BCRARL commented Aug 16, 2018

…me examples, and changed tests. This adds some compliance with v0.7. tests no longer fail, but I'm not sure my hack getting arguments from expressions is the right one.

@sjoelund
Copy link

It seems there are more changes in 0.7:

And the assignment to Base.ismatch fails in Julia 1.0.0 (which I think would be better to target than 0.7 since the language should be much more stable).

@kmsquire
Copy link
Contributor

Thanks for this! I'll take a look, but in the mean time, you should consider looking at Rematch.jl, which mostly reimplements Match.jl in a cleaner way.

@BCRARL
Copy link
Author

BCRARL commented Aug 17, 2018

This is not a complete update to 0.7/1.0 . I just fixed the stuff so my own code worked :-( -- and the tests.
0.7 is supposed to give us deprecation warnings. I received those for Range and included corrections for that. So by moving to 0.7 and then taking care of the deprecation warnings the code should be 1.0 compliant.
@kmsquire I'll take a look at Rematch.jl Does this mean Match.jl should be deprecated?

@kmsquire
Copy link
Contributor

Hi @BCRARL, thanks again for this merge request. I ended up making a slightly different set of changes (e.g., the parens aren't necessary for handling guard expressions).

Regarding Rematch.jl, it's missing some functionality that's here, but it's written in a more modern style. If I get around to it, I might update this code to match, but in the mean time, Rematch.jl works for you, it will probably be better maintained going into the future.

Cheers!

@kmsquire kmsquire closed this Aug 29, 2018
@BCRARL
Copy link
Author

BCRARL commented Aug 30, 2018

@kmsquire Thanks for updating. I'll consider Rematch.jl instead, although some of your choices fit my style better :-)

@BCRARL BCRARL deleted the v0.7 branch August 30, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants