Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suitable residual norm estimate in CR when a preconditioner is supplied #178

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

amontoison
Copy link
Member

fix #120
The problem came from the initialization of rNorm.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.154% when pulling e1292a5 on amontoison:cr into 868257f on JuliaSmoothOptimizers:master.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #178 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          28       28           
  Lines        2495     2495           
=======================================
  Hits         2424     2424           
  Misses         71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868257f...e1292a5. Read the comment docs.

@dpo
Copy link
Member

dpo commented Feb 28, 2020

GReat, thank you!

@dpo dpo merged commit 31c61f7 into JuliaSmoothOptimizers:master Feb 28, 2020
@amontoison amontoison deleted the cr branch August 4, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preconditioned CR
3 participants