Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for integer matrices #182

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

amontoison
Copy link
Member

  • Drop support for integer matrices (Wrap automatically preconditioners in a LinearOperator #181)
  • I also removed the variant for A and b with different type. If it's the case, we should not always convert b to a Vector. It could be a CuVector for example.
    -> The user should give A and b with the same type.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #182 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   97.15%   97.17%   +0.02%     
==========================================
  Files          28       28              
  Lines        2495     2478      -17     
==========================================
- Hits         2424     2408      -16     
+ Misses         71       70       -1
Impacted Files Coverage Δ
src/variants.jl 100% <ø> (ø) ⬆️
src/cg_lanczos.jl 100% <ø> (ø) ⬆️
src/diom.jl 93.58% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b487cbf...3c56bfa. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 13, 2020

Coverage Status

Coverage increased (+0.02%) to 97.175% when pulling 3c56bfa on amontoison:adios_int_matrices into b487cbf on JuliaSmoothOptimizers:master.

@amontoison
Copy link
Member Author

@dpo Can you merge this pull request? I want to rebase #181 and test it with CuArrays.

@dpo
Copy link
Member

dpo commented Mar 20, 2020

Yes. I was waiting yesterday for the Appveyor builds to finish, which was never happening... Thank you for this.

@dpo dpo merged commit 00183b3 into JuliaSmoothOptimizers:master Mar 20, 2020
@amontoison amontoison deleted the adios_int_matrices branch August 4, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants