Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preconditioned MINRES-QLP #200

Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented May 13, 2020

It was difficult to find memory for vₖ without allocating a new vector but I finally found it.

@amontoison
Copy link
Member Author

pull request n°200 💥

@coveralls
Copy link

coveralls commented May 13, 2020

Coverage Status

Coverage decreased (-0.03%) to 97.163% when pulling a907eaa on amontoison:minres-qlp-preconditioned into d85faa1 on JuliaSmoothOptimizers:master.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #200 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   97.19%   97.16%   -0.03%     
==========================================
  Files          28       28              
  Lines        2494     2503       +9     
==========================================
+ Hits         2424     2432       +8     
- Misses         70       71       +1     
Impacted Files Coverage Δ
src/minres_qlp.jl 100.00% <100.00%> (ø)
src/diom.jl 92.30% <0.00%> (-1.29%) ⬇️
src/cg.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2c4f4...a907eaa. Read the comment docs.

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

src/minres_qlp.jl Outdated Show resolved Hide resolved
@dpo
Copy link
Member

dpo commented Jul 1, 2020

Let's move SYMMLQ to a different PR, please.

@amontoison
Copy link
Member Author

I use this branch for something else, I didn't want to commit the modifications for SYMMLQ.

@amontoison amontoison force-pushed the minres-qlp-preconditioned branch from 8c5465f to a907eaa Compare July 1, 2020 18:39
@dpo dpo merged commit 3586f19 into JuliaSmoothOptimizers:master Jul 1, 2020
@dpo
Copy link
Member

dpo commented Jul 1, 2020

Thank you!

@amontoison amontoison deleted the minres-qlp-preconditioned branch August 4, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants