-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI scripts #211
Update CI scripts #211
Conversation
Thanks. Should we at least keep 1.3 since that's the minimum version in Project.toml? |
Yes, good idea. |
Any idea why this errors out only on AMD? https://travis-ci.org/github/JuliaSmoothOptimizers/Krylov.jl/jobs/722902656#L558 |
No 🤔 I modified the |
test/check_min_norm.jl
Outdated
@@ -7,7 +7,8 @@ function check_min_norm(A, b, x; λ=0.0) | |||
AI = A | |||
xI = x | |||
end | |||
xmin = AI' * ((AI * AI') \ b) | |||
QR = qr(AI * AI') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the problem is probably that Julia tries to compute the LU of AA', which is singular. But we only need the QR of A', not of AA'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right !
Still failing. How about |
I forgot to swap QR = qr(AI')
xmin = AI' * (QR.R \ (QR.R' \ b)) |
Sure, although multiplying by Q should be less prone to errors than another triangular solve and multiplying by A'. |
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 97.16% 97.26% +0.09%
==========================================
Files 28 29 +1
Lines 2504 2997 +493
==========================================
+ Hits 2433 2915 +482
- Misses 71 82 +11
Continue to review full report at Codecov.
|
🎉 |
No description provided.