Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriCG and TriMR examples #213

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Conversation

amontoison
Copy link
Member

No description provided.

@amontoison amontoison mentioned this pull request Sep 2, 2020
@coveralls
Copy link

coveralls commented Sep 2, 2020

Coverage Status

Coverage remained the same at 97.569% when pulling 9a769b8 on amontoison:examples into 099997f on JuliaSmoothOptimizers:master.

@@ -5,3 +5,4 @@ Examples in this folder require other Julia packages:
* [MatrixMarket.jl](https://github.com/JuliaSparse/MatrixMarket.jl)
* [HarwellRutherfordBoeing.jl](https://github.com/JuliaSparse/HarwellRutherfordBoeing.jl)
* [DistributedArrays.jl](https://github.com/JuliaParallel/DistributedArrays.jl)
* [LDLFactorizations.jl](https://github.com/JuliaSmoothOptimizers/LDLFactorizations.jl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there should be a Project.toml in this folder.

# [M A] [x] = [b]
# [Aᵀ -N] [y] [c]
ldlt_M = ldl(M)
ldlt_N = ldl(N)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need ldl() or is cholesly() sufficient for the example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cholesky() is sufficient but you need to allocate a new vector at each iteration when systems with sparse M and N are solved because lmul! is not implemented for SuiteSparse.CHOLMOD structure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give an example with both because of that.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          30       30           
  Lines        3233     3233           
=======================================
  Hits         3150     3150           
  Misses         83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099997f...9a769b8. Read the comment docs.

@dpo dpo merged commit 1a68857 into JuliaSmoothOptimizers:master Sep 3, 2020
@dpo
Copy link
Member

dpo commented Sep 3, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants