-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TriCG and TriMR examples #213
Conversation
examples/README.md
Outdated
@@ -5,3 +5,4 @@ Examples in this folder require other Julia packages: | |||
* [MatrixMarket.jl](https://github.com/JuliaSparse/MatrixMarket.jl) | |||
* [HarwellRutherfordBoeing.jl](https://github.com/JuliaSparse/HarwellRutherfordBoeing.jl) | |||
* [DistributedArrays.jl](https://github.com/JuliaParallel/DistributedArrays.jl) | |||
* [LDLFactorizations.jl](https://github.com/JuliaSmoothOptimizers/LDLFactorizations.jl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there should be a Project.toml
in this folder.
# [M A] [x] = [b] | ||
# [Aᵀ -N] [y] [c] | ||
ldlt_M = ldl(M) | ||
ldlt_N = ldl(N) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need ldl()
or is cholesly()
sufficient for the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cholesky()
is sufficient but you need to allocate a new vector at each iteration when systems with sparse M
and N
are solved because lmul!
is not implemented for SuiteSparse.CHOLMOD
structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give an example with both because of that.
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 30 30
Lines 3233 3233
=======================================
Hits 3150 3150
Misses 83 83 Continue to review full report at Codecov.
|
Thank you! |
No description provided.