Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve allocation tests #660

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

amontoison
Copy link
Member

  • Take into account that some vectors are real in the workspace (KrylovSolver) when we solve complex linear systems;
  • The functions that return the number of bits allocated by a method is now generic for matrices of size m x n;
  • Test with Float32 and ComplexF32.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 98.21% // Head: 98.21% // No change to project coverage 👍

Coverage data is based on head (c0d6f68) compared to base (bc93b54).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          37       37           
  Lines        6605     6605           
=======================================
  Hits         6487     6487           
  Misses        118      118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
Percival.jl
RipQP.jl

@amontoison amontoison merged commit ae3fc2d into JuliaSmoothOptimizers:main Oct 11, 2022
@amontoison amontoison deleted the allocations_test branch October 11, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant