Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final pass over paper #690

Merged
merged 4 commits into from
Nov 26, 2022
Merged

final pass over paper #690

merged 4 commits into from
Nov 26, 2022

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Nov 25, 2022

@amontoison amontoison requested a review from dpo November 25, 2022 06:48
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (joss-paper@f132cf4). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             joss-paper     #690   +/-   ##
=============================================
  Coverage              ?   98.19%           
=============================================
  Files                 ?       37           
  Lines                 ?     6600           
  Branches              ?        0           
=============================================
  Hits                  ?     6481           
  Misses                ?      119           
  Partials              ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
Percival.jl
RipQP.jl

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
amontoison and others added 2 commits November 25, 2022 10:30
Co-authored-by: Dominique <dominique.orban@gmail.com>
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amontoison amontoison merged commit 0d5b5e4 into joss-paper Nov 26, 2022
@amontoison amontoison deleted the alexis-pass branch November 26, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants