Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the JOSS paper with the comments of prj- #713

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Improve the JOSS paper with the comments of prj- #713

merged 2 commits into from
Mar 24, 2023

Conversation

amontoison
Copy link
Member

For the JOSS review of Krylov.jl

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
Percival.jl
RipQP.jl

dpo
dpo reviewed Mar 7, 2023
View reviewed changes
paper/paper.md Outdated Show resolved Hide resolved
@amontoison @dpo
Update paper/paper.md
12f390d 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
Copy link
Member Author

Thanks Dominique! I will open another PR for the remaining comments.

@amontoison amontoison merged commit 662176f into JuliaSmoothOptimizers:joss-paper Mar 24, 2023
@amontoison amontoison deleted the review_joss branch March 24, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpo dpo dpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @dpo