Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adress the remaining comments of prj- #720

Merged
merged 7 commits into from
Mar 27, 2023
Merged

Adress the remaining comments of prj- #720

merged 7 commits into from
Mar 27, 2023

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Mar 25, 2023 •
edited
Loading

For the JOSS review of Krylov.jl:

  • I removed CI scripts not relevant for the JOSS paper;
  • We now use Buildkite on the joss-paper branch to test the examples;
  • I pushed the example files with their respective Project.toml / Manifest.toml;
  • Take into account the remaining comments of prj- .

@dpo Can you check the commit 6a25300 when you will have a few minutes?

@amontoison amontoison requested a review from dpo March 25, 2023 20:39
@amontoison amontoison changed the title Adress the last comments of prj- Adress the remaining comments of prj- Mar 25, 2023
@amontoison amontoison mentioned this pull request Mar 25, 2023
Closed
dpo
dpo requested changes Mar 26, 2023
View reviewed changes
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
amontoison and others added 2 commits March 26, 2023 17:59
@amontoison @dpo
Apply suggestions from code review
aab698a 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
\testsc -> \textsc
463f8e9
@amontoison amontoison merged commit 137693e into JuliaSmoothOptimizers:joss-paper Mar 27, 2023
@amontoison amontoison deleted the joss-paper branch March 27, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpo dpo dpo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @dpo