-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use metaprogramming to define the kwargs of all Krylov methods #735
Use metaprogramming to define the kwargs of all Krylov methods #735
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 38 38
Lines 6861 6898 +37
==========================================
+ Hits 6743 6779 +36
- Misses 118 119 +1
☔ View full report in Codecov by Sentry. |
deb9c1c
to
5f546b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amontoison !
It looks good to me. I guess this will increase the pre-compilation of the package though, but that's alright for now.
No, the functions were already precompiled. The in-place methods (without warm-start) were already correctly precompiled. |
Thanks @mosullivan93 for your help with metaprogramming!
@dpo @tmigot Julia will not recompile the non in-place methods anymore if we use different keyword arguments.
It will be also easier to maintain.
ps: I found some mistakes in the docstrings of
CRLS
,CGLS
,CGNE
andCRMR
.