Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timemax when a KrylovSolver is allocated #743

Merged
merged 1 commit into from
May 11, 2023

Conversation

amontoison
Copy link
Member

Take into account the time to allocate the KrylovSolver and perform warm-start when the timemax option is used.

and perform warm-start when the timemax option is used
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.56 ⚠️

Comparison is base (b22e980) 96.99% compared to head (3d3fe56) 96.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   96.99%   96.43%   -0.56%     
==========================================
  Files          38       38              
  Lines        6887     7041     +154     
==========================================
+ Hits         6680     6790     +110     
- Misses        207      251      +44     
Impacted Files Coverage Δ
src/bicgstab.jl 95.31% <66.66%> (-1.41%) ⬇️
src/bilq.jl 96.51% <66.66%> (-1.08%) ⬇️
src/bilqr.jl 97.48% <66.66%> (-0.80%) ⬇️
src/cg.jl 95.12% <66.66%> (-1.46%) ⬇️
src/cg_lanczos.jl 95.12% <66.66%> (-1.46%) ⬇️
src/cgs.jl 95.27% <66.66%> (-1.42%) ⬇️
src/cr.jl 65.80% <66.66%> (+0.02%) ⬆️
src/diom.jl 95.89% <66.66%> (-1.26%) ⬇️
src/dqgmres.jl 95.91% <66.66%> (-1.25%) ⬇️
src/fgmres.jl 96.72% <66.66%> (-1.02%) ⬇️
... and 23 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
LinearSolve.jl
Percival.jl
RipQP.jl

src/bicgstab.jl Show resolved Hide resolved
src/bicgstab.jl Show resolved Hide resolved
@amontoison amontoison merged commit 5f7ea0f into JuliaSmoothOptimizers:main May 11, 2023
@amontoison amontoison deleted the timemax_update branch May 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants