Use artifact MUMPS_jll #80

amontoison · 2022-01-07T09:32:36Z

close #53

codecov · 2022-01-07T09:55:31Z

Codecov Report

❗ No coverage uploaded for pull request base (main@955e302). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   17.99%           
=======================================
  Files           ?       10           
  Lines           ?      889           
  Branches        ?        0           
=======================================
  Hits            ?      160           
  Misses          ?      729           
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dpo · 2022-01-11T22:13:54Z

Let's not remove the old interface until everything works. That will also help keep this PR more focused.

amontoison · 2022-01-11T22:46:46Z

Let's not remove the old interface until everything works. That will also help keep this PR more focused.

I updated the PR to not remove the old interface except deps/build.jl.

I added a ci2.yml to test MUMPS.jl with artifact MUMPS_jll because I updated the interface such that the users can use their own installation of MUMPS if the environment variable MUMPS_PREFIX is defined.
All tests with ci.yml still use your tap dpo/mumps-jl.

dpo · 2022-01-12T00:32:33Z

I added a ci2.yml to test MUMPS.jl with artifact MUMPS_jll because I updated the interface such that the users can use their own installation of MUMPS if the environment variable MUMPS_PREFIX is defined.
All tests with ci.yml still use your tap dpo/mumps-jl.

Right, but it can no longer be built...

Also, why do we need to install all three oh OpenMPI, MPICH and MicrosoftMPI???

amontoison · 2022-01-12T11:10:45Z

I added a ci2.yml to test MUMPS.jl with artifact MUMPS_jll because I updated the interface such that the users can use their own installation of MUMPS if the environment variable MUMPS_PREFIX is defined.
All tests with ci.yml still use your tap dpo/mumps-jl.

Right, but it can no longer be built...

I found a solution to keep it.

Also, why do we need to install all three oh OpenMPI, MPICH and MicrosoftMPI???

OpenMPI, MPICH and MicrosoftMPI are dependencies of MPI.jl (https://github.com/JuliaParallel/MPI.jl/blob/master/Project.toml#L10-L13).
They are also required for MPItrampoline_jll.

dpo · 2022-01-12T18:54:47Z

#81 should fix the test that fails on macOS related to accuracy.

There's still a segfault with the JLL to investigate.

dpo

It all looks great, many thanks! I would prefer to leave MUMPS.jl and mumps_types.jl unchanged in this PR and update MUMPS-C_API.jl instead.

amontoison · 2022-01-13T09:59:51Z

#81 should fix the test that fails on macOS related to accuracy.

There's still a segfault with the JLL to investigate.

I don't know why there is a segfault on OSX.
I recompiled everything with Yggdrasil :(

dpo · 2022-01-13T14:52:37Z

I'll try locally.

src/MUMPS.jl

src/MUMPS_C-API.jl

dpo · 2022-01-14T01:36:38Z

ps: at least, Homebrew is also installing binaries now, which speeds up the CI (https://github.com/JuliaSmoothOptimizers/MUMPS.jl/runs/4811639965?check_suite_focus=true#step:3:59).

pps: MUMPS itself is still being compiled on Linux... not sure why.

amontoison · 2022-01-14T22:01:09Z

ps: at least, Homebrew is also installing binaries now, which speeds up the CI (https://github.com/JuliaSmoothOptimizers/MUMPS.jl/runs/4811639965?check_suite_focus=true#step:3:59).

Great !

pps: MUMPS itself is still being compiled on Linux... not sure why.

MUMPS is not compiled with my ci2.yml (https://github.com/JuliaSmoothOptimizers/MUMPS.jl/runs/4811022469?check_suite_focus=true).
Maybe we should update the build name of ci.yml and ci2.yml.
Instead of CI, we could rename them CI-Homebrew and CI-Artifact.

dpo · 2022-01-22T05:51:47Z

I can reproduce the segmentation fault locally on macOS... :-(

amontoison · 2022-01-27T18:33:31Z

@dpo I recompiled MUMPS_jll on my computer for x86_64-linux-gnu and x86_64-apple-darwin platforms without ParMETIS and deployed the new MUMPS_jll (fork amontoison/MUMPS_jll.jl).
We still have the segmentation fault on OSX :(

dpo · 2022-01-27T18:48:02Z

😞
It's hard to debug. I tried to follow the execution with dtrace and saw messages that suggested ParMETIS as a potential problem. I'll look more when I find a moment.

amontoison · 2022-02-07T04:44:52Z

The version 2.2.0 of SCALAPACK was released four days ago: http://www.netlib.org/scalapack/#_scalapack_version_2_2_0
I compiled it with Yggdrasil: JuliaPackaging/Yggdrasil#4368
It could fix our issue with Mac 🤞

amontoison · 2022-02-08T05:11:38Z

SCALAPACK 2.2.0 doesn't solved our issue but I found a topic about our segfault: https://developer.apple.com/forums/thread/121887
The solution is to recompile with -fno-stack-check flag.

dpo · 2022-02-08T06:01:02Z

I tried that 10 days ago, but it didn't help. Maybe I didn't recompile Scalapack with it though. I'll have to try.

amontoison · 2022-08-19T04:27:34Z

@dpo MUMPS_jll works on Linux and Mac !!! 🎉

dpo · 2022-08-19T19:46:34Z

Excellent, thank you! I'm going to merge this despite the failing Homebrew actions. In the next PR, I'll remove the Homebrew actions and add M1.

amontoison · 2022-08-19T19:54:52Z

We can also test FreeBSD with CirrusCI :-)

amontoison force-pushed the update_mumps branch from acb3131 to 5245522 Compare January 7, 2022 09:45

amontoison changed the title ~~Remove old interface and use Artifacts MUMPS_jll 5.4.1~~ Remove old interface and use Artifacts MUMPS_jll 5.4.2 Jan 11, 2022

amontoison force-pushed the update_mumps branch from 08607b8 to 64f3fa2 Compare January 11, 2022 22:09

amontoison force-pushed the update_mumps branch from 64f3fa2 to b56091d Compare January 11, 2022 22:31

amontoison requested a review from dpo January 11, 2022 22:32

amontoison changed the title ~~Remove old interface and use Artifacts MUMPS_jll 5.4.2~~ Use artifact MUMPS_jll Jan 11, 2022

amontoison force-pushed the update_mumps branch from 5da0d6e to cd574cb Compare January 12, 2022 10:59

dpo reviewed Jan 12, 2022

View reviewed changes

amontoison force-pushed the update_mumps branch from f983f39 to 50b7dff Compare January 13, 2022 09:52

dpo requested changes Jan 13, 2022

View reviewed changes

src/MUMPS.jl Outdated Show resolved Hide resolved

src/MUMPS.jl Outdated Show resolved Hide resolved

src/MUMPS.jl Outdated Show resolved Hide resolved

src/MUMPS_C-API.jl Outdated Show resolved Hide resolved

src/MUMPS_C-API.jl Outdated Show resolved Hide resolved

amontoison force-pushed the update_mumps branch 2 times, most recently from 5d7a1ac to 8e4d47d Compare January 27, 2022 18:22

amontoison force-pushed the update_mumps branch from 8e4d47d to cbaeeee Compare February 8, 2022 03:51

Use Artifact MUMPS_jll

d16299c

amontoison added 4 commits August 16, 2022 04:25

Update deps/build.jl

d3d97b4

Update MUMPS-C_API.jl

219d8b3

Add @dpo review comments

d9c68f5

Update GitHub Actions files

096b00c

amontoison force-pushed the update_mumps branch from cbaeeee to 096b00c Compare August 16, 2022 08:39

Use MUMPS_jll 5.5.1

e05714a

dpo merged commit 92aa50c into JuliaSmoothOptimizers:main Aug 19, 2022

amontoison deleted the update_mumps branch August 19, 2022 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use artifact MUMPS_jll #80

Use artifact MUMPS_jll #80

amontoison commented Jan 7, 2022 •

edited

Loading

codecov bot commented Jan 7, 2022 •

edited

Loading

dpo commented Jan 11, 2022

amontoison commented Jan 11, 2022 •

edited

Loading

dpo commented Jan 12, 2022

amontoison commented Jan 12, 2022 •

edited

Loading

dpo commented Jan 12, 2022

dpo left a comment

amontoison commented Jan 13, 2022

dpo commented Jan 13, 2022

dpo commented Jan 14, 2022

amontoison commented Jan 14, 2022

dpo commented Jan 22, 2022

amontoison commented Jan 27, 2022 •

edited

Loading

dpo commented Jan 27, 2022

amontoison commented Feb 7, 2022 •

edited

Loading

amontoison commented Feb 8, 2022

dpo commented Feb 8, 2022

amontoison commented Aug 19, 2022

dpo commented Aug 19, 2022

amontoison commented Aug 19, 2022

Use artifact MUMPS_jll #80

Use artifact MUMPS_jll #80

Conversation

amontoison commented Jan 7, 2022 • edited Loading

codecov bot commented Jan 7, 2022 • edited Loading

Codecov Report

dpo commented Jan 11, 2022

amontoison commented Jan 11, 2022 • edited Loading

dpo commented Jan 12, 2022

amontoison commented Jan 12, 2022 • edited Loading

dpo commented Jan 12, 2022

dpo left a comment

Choose a reason for hiding this comment

amontoison commented Jan 13, 2022

dpo commented Jan 13, 2022

dpo commented Jan 14, 2022

amontoison commented Jan 14, 2022

dpo commented Jan 22, 2022

amontoison commented Jan 27, 2022 • edited Loading

dpo commented Jan 27, 2022

amontoison commented Feb 7, 2022 • edited Loading

amontoison commented Feb 8, 2022

dpo commented Feb 8, 2022

amontoison commented Aug 19, 2022

dpo commented Aug 19, 2022

amontoison commented Aug 19, 2022

amontoison commented Jan 7, 2022 •

edited

Loading

codecov bot commented Jan 7, 2022 •

edited

Loading

amontoison commented Jan 11, 2022 •

edited

Loading

amontoison commented Jan 12, 2022 •

edited

Loading

amontoison commented Jan 27, 2022 •

edited

Loading

amontoison commented Feb 7, 2022 •

edited

Loading