Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartitionedNLPModel relying on PartitionedVectors #59

Merged
merged 21 commits into from
Dec 15, 2022

Conversation

paraynaud
Copy link
Member

@dpo great news, I defined the first partitioned quasi-Newton NLPModels relying fully on PartititonedVectors!
Moreover, trunk() works (from my TrunkSolver constructor).

Locally, the following script is running:

using ADNLPModels, NLPModels
using OptimizationProblems, OptimizationProblems.PureJuMP, OptimizationProblems.ADNLPProblems
using JSOSolvers
using PartiallySeparableNLPModels

adnlp = ADNLPProblems.arwhead(; n)
pqnnlp = PVQNPModel(adnlp)
ps_ges = trunk(pqnnlp)
sol_ps = ps_ges.solution
NLPModels.obj(adnlp, sol_ad) #1.7053025658242404e-13

For now I defined only one PQNNLPModel, I still have to define the others PQNNLPModels and then I will clean up the repository.
Once this stuff is stable, I will release the v0.1.0 of PartitionedVectors.jl and I will register it.
PartitionedStructures.jl will have a new release which will be propagate up to this repository.

@dpo
Copy link
Member

dpo commented Sep 29, 2022

@paraynaud Great news! Congratulations! I'm looking forward to seeing it in action!

@paraynaud
Copy link
Member Author

paraynaud commented Nov 14, 2022

Require new releases of:

@paraynaud paraynaud force-pushed the pr-PartitionedTrunk branch 2 times, most recently from c5f90ab to 1670bcf Compare December 15, 2022 11:18
@paraynaud
Copy link
Member Author

After an error preventing the build of ExpressionTreeForge.jl due to RecipesBase.jl.
The error resolved itself, I think the PR is ready to go.

@paraynaud paraynaud requested review from amontoison and dpo December 15, 2022 15:32
Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul, il y a trop de modifications. Je te fais confiance et j'approuve la PR histoire de ne pas te bloquer.

@paraynaud
Copy link
Member Author

Paul, il y a trop de modifications. Je te fais confiance et j'approuve la PR histoire de ne pas te bloquer.

Merci, les prochaines PR seront plus légères, promis!

@paraynaud paraynaud merged commit e224c6b into master Dec 15, 2022
@paraynaud paraynaud deleted the pr-PartitionedTrunk branch December 15, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants