Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Travis' Julia / Codecov / Coveralls support #7

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Use Travis' Julia / Codecov / Coveralls support #7

merged 1 commit into from
Mar 5, 2019

Conversation

fingolfin
Copy link
Contributor

No description provided.

@fingolfin
Copy link
Contributor Author

It seems you disabled Travis for pull requests, so this won't get tested :-(

@ronisbr ronisbr merged commit b97175c into JuliaSpace:master Mar 5, 2019
@fingolfin fingolfin deleted the patch-1 branch March 5, 2019 14:15
@fingolfin
Copy link
Contributor Author

Uhh, OK... now I just hope it doesn't break... Any particular reason you don't want PRs to be tested? To me, that's one of the primary benefits of using a service like Travis.

@ronisbr
Copy link
Member

ronisbr commented Mar 5, 2019

No, actually, I am not sure why I disabled it. It is enabled now.

@fingolfin
Copy link
Contributor Author

(Oh, and of course the Julia 1.0 and 1.1 builds will fail anyway, due to JuliaLang/MbedTLS.jl#193

@ronisbr
Copy link
Member

ronisbr commented Mar 5, 2019

Yeah, I just saw this :) However, your patch seems to be working OK, since the process to submit to Coverage and Coveralls was executed.

@fingolfin
Copy link
Contributor Author

yeah, phew, that's a relief :) I am rather heavily depending on Travis double checking my PRs these days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants