Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading Pardiso on mac when MKL does not support it #95

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

KristofferC
Copy link
Member

Fixes #94

cc @ViralBShah, @mipals

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a43a6e4) 39.57% compared to head (4c0e21f) 39.68%.

Files Patch % Lines
src/Pardiso.jl 75.00% 1 Missing ⚠️
src/mkl_pardiso.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   39.57%   39.68%   +0.11%     
==========================================
  Files           4        4              
  Lines         374      378       +4     
==========================================
+ Hits          148      150       +2     
- Misses        226      228       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristofferC KristofferC merged commit e62b47a into master Feb 14, 2024
8 of 11 checks passed
@KristofferC KristofferC deleted the kc/mkl_mac branch February 14, 2024 16:02
@ViralBShah ViralBShah mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error trying to load MKL on M1 macbook (even when trying to use Pardiso 8.0)
2 participants