Removing hard-coded MKL in tests #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to pin MKL_jll to 2023 for macOS. Furthermore making the examples functions to take in the available solvers.
Fixing mistakes in the test examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 39.68% 39.68%
=======================================
Files 4 4
Lines 378 378
=======================================
Hits 150 150
Misses 228 228 ☔ View full report in Codecov by Sentry. |
|
MKL_jll 2023 seem to work fine on macOS #96 |
|
Update README to say to use 2023 instead? After that, LGTM. |
|
So, should i merge? |
|
👍 go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try to make tests available for Panua-Pardiso when MKL is not installed as noted in #96 . Not all tests passes, however, as there is currently some issues with the err returned in Panua-Pardiso 7.2 and upwards (as discussed in #75 ).
In addition MKL_jll is pinned to 2023 in testing for macOS on intel machines.
The examples is also make into functions with either
MKLPardisoSolverorPardisoSolveras inputs. Currently the functions just wraps the old code. This can definitely be made cleaner.