-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparseMatrixCSR should be a type alias for Transpose{SparseMatrixCSC} #41
Comments
Do you mean |
I was originally using This would necessitate some built out of operations on The benefit would be that it would standardize the ecosystem to using the |
It would, believe me. I am working on general wrappers of sparse matrices for a while now. Best what was recently merged into julia1.2 are conversions of wrapped sparse to |
I am inclined to close this one, as a substantial rewrite that results out of this should perhaps be done in an external package. |
I think that at it's simplest this would only be a single lined alias, with a few more lines to for a "constructor function" and convert. Give me a few weeks to put together the basic PR |
If we introduce this, pretty much everything has to work on it and we have to field issues around performance that come up. I would be curious to see how far we can get. |
Is the recursive nature of transpose an obstacle here? |
I think this can easily be experimented with in a package called |
I am surprised that this isn't already in SparseArray, but should we define:
const SparseMatrixCSR{Tv,Ti} = Transpose{Tv,SparseMatrix{Tv,Ti}} where {Tv, Ti <: Integer}
This plus a few simple additional methods would make it so Julia had psuedo built in support for compressed sparse matrixes.
I am already using a definition like this and I can't believe that I am the only one.
If people agree I can take a shot at the PR.
The text was updated successfully, but these errors were encountered: