Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conservative OSes #164

Closed
wants to merge 1 commit into from
Closed

Use conservative OSes #164

wants to merge 1 commit into from

Conversation

ViralBShah
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #164 (eeda28a) into main (f57af69) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   34.25%   34.25%   -0.01%     
==========================================
  Files          25       25              
  Lines       21130    21130              
==========================================
- Hits         7239     7238       -1     
- Misses      13891    13892       +1     
Impacted Files Coverage Δ
src/linalg.jl 84.50% <0.00%> (-0.09%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@DilumAluthge
Copy link
Contributor

Looks like your hypothesis (that 2016 is too recent to trigger the bug) is correct.

If necessary, @staticfloat and I can work with you to figure out how to use Buildkite to set up Windows 7 CI on this repository.

@ViralBShah
Copy link
Member Author

I don't think it is worthwhile to worry about Windows 7 CI. It would be good to just fix the Float16 issue.

@ViralBShah ViralBShah closed this Jun 25, 2022
@DilumAluthge DilumAluthge deleted the vs/old-oses branch June 25, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants