Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with 32-bit SuiteSparse 7 #372

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Deal with 32-bit SuiteSparse 7 #372

merged 1 commit into from
Mar 25, 2023

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah changed the title Deal with 32-bit SuiteSparse Deal with 32-bit SuiteSparse 7 Mar 25, 2023
Regenerate wrappers
@Gnimuc
Copy link
Member

Gnimuc commented Mar 26, 2023

A more proper fix would be to add these compiler flags to

args = get_default_args(target)
push!(args, "-I$include_dir")

@Gnimuc
Copy link
Member

Gnimuc commented Mar 26, 2023

But it seems those flags only affect SuiteSparse_long, so the fix in this PR is also valid and stable.

@ViralBShah
Copy link
Member Author

ViralBShah commented Mar 26, 2023

Yes, it seems like we don't need SuiteSparse_long at all (it is deprecated in SuiteSparse 7), and even those compiler flags are only relevant for SuiteSparse internally calling BLAS. The BLAS related flags don't seem to make an appearance in the header files we process.

Let's see if JuliaLang/julia#48977 with the new builds works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants