Assorted mul rules #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2021 16:51
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 33.18% 33.88% +0.69%
==========================================
Files 34 34
Lines 2751 2783 +32
==========================================
+ Hits 913 943 +30
- Misses 1838 1840 +2
Continue to review full report at Codecov.
|
Member
Author
|
I'm actually just going to merge this since I believe they're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR for some additional rules. I believe these are correct.
Note: Larger matrices, especially dense ones, run into floating point issues for
isapprox. I'm not sure if I should be bothered by that or not.