Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

isna() for scalar case #163

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Conversation

alyst
Copy link
Member

@alyst alyst commented Aug 26, 2015

It significantly reduces memory allocation overhead in DataFrames for me on 0.4.

johnmyleswhite added a commit that referenced this pull request Aug 26, 2015
@johnmyleswhite johnmyleswhite merged commit 32a781c into JuliaStats:master Aug 26, 2015
@johnmyleswhite
Copy link
Member

It seems like we're probably being too liberal with indexing if this is needed since I would have thought the other cases would handle this.

@simonster
Copy link
Member

Most likely there is an issue with Compat's @nsplat. In any case once we can drop 0.3 support we should replace as much of the Cartesian use as possible with generic functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants