Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distances with missing values #11

Closed
bdeonovic opened this issue May 6, 2015 · 5 comments
Closed

Distances with missing values #11

bdeonovic opened this issue May 6, 2015 · 5 comments

Comments

@bdeonovic
Copy link

I saw this issue on DataFrames (JuliaData/DataFrames.jl#183), and noted that it was from a few years ago. Is there support for missing values in Distances.jl yet?

@johnmyleswhite
Copy link
Member

No, there is not. Pull requests would be reviewed I'm sure, although I imagine that Distances.jl shouldn't depend upon DataArrays.

@lindahua
Copy link
Contributor

lindahua commented May 8, 2015

I think supporting missing value is not in the scope of this package (at least at this point).

zgornel added a commit to zgornel/Distances.jl that referenced this issue Jan 14, 2019
@oxinabox
Copy link

We should come back and do this now that Missing data handling is in Base.

@KristofferC
Copy link
Member

There should be no need for special handling of Missing here.

Agreed with #11 (comment)

@rofinn
Copy link
Member

rofinn commented Dec 28, 2023

FWIW, I found a specific use case where supporting missings here would help the larger ecosystem. Specifically, Distances.jl -> NearestNeighbors.jl -> Impute.jl.

invenia/Impute.jl#141 (comment)

Impute.jl isn't getting a lot of active development anymore, so I understand if it isn't worth the change, but updating Distances.jl and NearestNeighbors.jl seems like the best approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants