-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods for working with distribution support added for univariate distributions #149
Conversation
…istributions. Please review carefully (repetetive work, easy to make mistakes). Wasn't sure about EdgeworthAbstract distribution.
|
||
|
||
#min(d::Beta) = zero(Real) # maybe inf(::Beta) = 0 would make sense | ||
#max(d::Beta) = one(Real) # and sup(::Beta) = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consensus in #150 seems to be use min/max to get infimum and supremum even when the domain is open. what about uncommenting these functions (as well as other commented out min/max)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's use min
and max
. Do zero(Real)
and one(Real)
exist? I think only zero(Float64)
and one(Float64)
will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested for the existance of zero(Real)
and one(Real)
on the julia command line, gave the expected results.
I believe this is largely ready, except several minor things:
|
Methods for working with distribution support added for univariate distributions
Thanks! I will take care of those minor things. |
Support handling of all remaining univariate distributions is completed in commit 013643b. |
Great, thanks a lot for doing the rest |
This is the first batch of implementations to fix #126. Please review carefully (repetetive work, easy to make mistakes).
Wasn't sure about EdgeworthAbstract distribution.