Add functions for the hypergeometric distribution #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BigCrunsh
commented
Jul 9, 2014
BigCrunsh
commented
- add support
- add mode, skewness, kurtosis
- add tests
|
This seems to be stuck on a file not found error. |
|
Yes... Forgot the testfile 🐤 Thx. |
|
Would you please add the documents? |
|
|
||
| function modes(d::Hypergeometric) | ||
| if (d.ns == d.nf) && mod(d.n, 2) == 1 | ||
| [(d.n-1)/2 (d.n+1)/2] |
There was a problem hiding this comment.
[x y] returns a 2x1 matrix, you should use [x, y] which will return a vector.
|
@lindahua: Which documents do you mean? |
- add support - add mode, skewness, kurtosis - add tests
|
I just noticed that you have already add an entry to |
lindahua
added a commit
that referenced
this pull request
Jul 19, 2014
Add functions for the hypergeometric distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.