Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tolerance to decide on step size in line search #226

Merged
merged 2 commits into from
May 9, 2018
Merged

Use tolerance to decide on step size in line search #226

merged 2 commits into from
May 9, 2018

Conversation

andreasnoack
Copy link
Member

Fixes #224

Also reorganize some tests and add comments to _fit!.

@andreasnoack andreasnoack mentioned this pull request May 2, 2018
Closed
@andreasnoack
Copy link
Member Author

I think this also fixes #105

@andreasnoack
Copy link
Member Author

So tests were failing because of unrelated issues fixed in #227 so this should now be ready.

@nalimilan nalimilan requested a review from dmbates May 3, 2018 10:23
@andreasnoack andreasnoack merged commit 1702d3c into master May 9, 2018
@andreasnoack andreasnoack deleted the anj/toldev branch May 9, 2018 08:10
@andreasnoack andreasnoack mentioned this pull request May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbates dmbates Awaiting requested review from dmbates

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreasnoack