Throw an error in predict with intervals for rank-deficient models
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`predict` currently gives incorrect intervals when some variables have been dropped due to collinearity. Throw an error instead to avoid misleading users, until we find a fix.
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 83.35% 84.17% +0.82%
==========================================
Files 6 6
Lines 769 771 +2
==========================================
+ Hits 641 649 +8
+ Misses 128 122 -6
Continue to review full report at Codecov.
|
ararslan
approved these changes
Jun 22, 2021
Co-authored-by: Alex Arslan <ararslan@comcast.net>
|
Thanks! I've filed #439 to release 1.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
predictcurrently gives incorrect intervals when some variables have been dropped due to collinearity. Throw an error instead toavoid misleading users, until we find a fix.
See #410 (comment).