Manual improvements #520
Open
Manual improvements #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 88.75% 89.32% +0.57%
==========================================
Files 8 8
Lines 1040 1040
==========================================
+ Hits 923 929 +6
+ Misses 117 111 -6 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bkamins
reviewed
Mar 25, 2023
| @@ -22,14 +22,14 @@ Their arguments must be: | |||
| then a valid formula is `@formula(Y ~ X1 + X2)` | |||
| - `data`: a table in the Tables.jl definition, e.g. a data frame; | |||
| rows with `missing` values are ignored | |||
| - `X` a matrix holding values of the independent variable(s) in columns | |||
There was a problem hiding this comment.
so maybe also add features/target as this is a common term tuple in ML?
There was a problem hiding this comment.
Thanks for the great suggestion, done 👍
|
Thank you. Let us wait for GLM.jl maintainers to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention independent/predictor variables and dependent/response variables at the same time at the top of the documentation.
Minor edits that do not change the context.