Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QR based fitting #559

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix QR based fitting #559

wants to merge 5 commits into from

Commits on Sep 30, 2024

  1. Remove white space

    @andreasnoack
    andreasnoack committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e661296 View commit details
    Browse the repository at this point in the history

  2. Fix QR based fitting 

    Avoid erroring out for low rank design matrices when dropcollinear=false.
Avoid unnecessary triangular solves. Avoid indexing in the Q.
Avoid slicing R matrix in a way that triggers a minimum norm solution.
Remove unnecessary temporaries.
    @andreasnoack
    andreasnoack committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    10f8528 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Address review comments

    @andreasnoack
    andreasnoack committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fffd07d View commit details
    Browse the repository at this point in the history

  2. Try to run docs on lts

    @andreasnoack
    andreasnoack committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0c95f73 View commit details
    Browse the repository at this point in the history

  3. Use a "mirror" for the test data

    @andreasnoack
    andreasnoack committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2b61e90 View commit details
    Browse the repository at this point in the history