Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loess dispatch to avoid infinite recursion #91

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

frankier
Copy link
Contributor

Fixes #60

@andreasnoack
Copy link
Member

Thanks for looking into this. Could you please add a test as well?

@frankier frankier force-pushed the fix-loess-dispatch branch from e211157 to 5286502 Compare August 26, 2024 10:04
@frankier
Copy link
Contributor Author

I guess a regression test (as added now) works?

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (e905c08) to head (5286502).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   85.90%   86.03%   +0.12%     
==========================================
  Files           2        2              
  Lines         220      222       +2     
==========================================
+ Hits          189      191       +2     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankier
Copy link
Contributor Author

Anything else to do here?

Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been great to also run the benchmarks but it seems impossible to get the working when the PR is from a fork, see #96. Anyway, this should be good. Thanks again for fixing this.

@andreasnoack andreasnoack merged commit 060956f into JuliaStats:master Aug 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loess crashes with StackOverflowError when missing values are present
3 participants