Force non-zero step size for general optimization after boundary fit in fast=true #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 92.96% 94.93% +1.97%
==========================================
Files 18 18
Lines 1294 1166 -128
==========================================
- Hits 1203 1107 -96
+ Misses 91 59 -32
Continue to review full report at Codecov.
|
palday
force-pushed
the
glmm_boundary_genopt
branch
from
348b12c
to
d8e668d
Compare
|
Stung by floating point comparison. I'll fix that. |
palday
force-pushed
the
glmm_boundary_genopt
branch
2 times, most recently
from
923e233
to
e5aae50
Compare
|
Optimization gives different results on different platforms, but neither is the 'correct' answer, see #206. |
palday
force-pushed
the
glmm_boundary_genopt
branch
from
e5aae50
to
4b277e5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94, Closes #95.
For boundary fits in GLMM, the initial step for general optimization in
fast=falseincludes a zero in (at least) one dimension. This forces that to be nonzero by replacing zeros with the smallest nonzero value.Note: this will not address models where everything is zero (including fixed effects), but that's another can of worms.