Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

[RFC/WIP] Few additional methods #155

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[RFC/WIP] Few additional methods #155

wants to merge 9 commits into from

Commits on Jul 12, 2017

  1. fix typo (mapreduce -> reduce)

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    e1610bf View commit details
    Browse the repository at this point in the history

  2. fix whitespace

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    747a541 View commit details
    Browse the repository at this point in the history

  3. fix mapreduce_skipnull for single nonnull element

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    214386b View commit details
    Browse the repository at this point in the history

  4. fix mapreduce() if all values are null + tests 

    * mapreduce() returns Nullable{T}(mr_empty) instead of just mr_empty
* added tests for [map]reduce() over non-empty collection that
  contain no non-null
    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    eb82854 View commit details
    Browse the repository at this point in the history

  5. add comments to unsafe_getXXX_notnull()

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    27775a2 View commit details
    Browse the repository at this point in the history

  6. add isnull(AbstractArray{Nullable}, i) fallback

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    3f6685f View commit details
    Browse the repository at this point in the history

  7. unsafe_xxx_notnull(AbstrArr{Nullable{T}}) fallback

    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    3e56713 View commit details
    Browse the repository at this point in the history

  8. annotate more indexing methods with @inline 

    should have the same effect as @propagate_inbounds within @inbounds
blocks
    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    9643fb2 View commit details
    Browse the repository at this point in the history

  9. mapreduce(): don't scan for missing values twice 

    since _mapreduce_skipnull() counts the number of nulls anyway, it
doesn't need the `missingdata` parameter
    @alyst
    alyst committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    3dab600 View commit details
    Browse the repository at this point in the history