Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support InverseFunctions where applicable #130

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Support InverseFunctions where applicable #130

merged 4 commits into from
Nov 10, 2021

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Nov 8, 2021

devmotion
devmotion reviewed Nov 8, 2021
View reviewed changes
src/inverse.jl Outdated Show resolved Hide resolved
test/inverse.jl Outdated Show resolved Hide resolved
@oschulz @devmotion
Simplify inverse definitions
888a391 
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@oschulz
Copy link
Contributor Author

oschulz commented Nov 8, 2021

Can you start CI, @devmotion ?

@oschulz
Copy link
Contributor Author

oschulz commented Nov 8, 2021

Can you start CI again, @devmotion ?

@codecov-commenter
Copy link

Codecov Report

Merging #130 (68de345) into master (f13b618) will increase coverage by 1.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   37.55%   38.73%   +1.17%     
==========================================
  Files          12       13       +1     
  Lines         418      426       +8     
==========================================
+ Hits          157      165       +8     
  Misses        261      261
Impacted Files Coverage Δ
src/inverse.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13b618...68de345. Read the comment docs.

@oschulz
Copy link
Contributor Author

oschulz commented Nov 8, 2021 •
edited
Loading

Test failures seem unrelated to this PR.

devmotion
devmotion approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@devmotion devmotion merged commit 69e6345 into JuliaStats:master Nov 10, 2021
@oschulz
Copy link
Contributor Author

oschulz commented Nov 10, 2021

Thanks!

@oschulz oschulz deleted the inverses branch November 10, 2021 23:54
@oschulz oschulz mentioned this pull request Nov 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oschulz @codecov-commenter @devmotion